Skip to content

Prefix CMake variables/options #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seanmiddleditch opened this issue Jun 22, 2019 · 2 comments
Closed

Prefix CMake variables/options #3

seanmiddleditch opened this issue Jun 22, 2019 · 2 comments

Comments

@seanmiddleditch
Copy link

The CMakeLists.txt currently unprefixed variables like SECURE or OVERRIDE. This can be messy and problematic when mimalloc is added to a project via add_subdirectory. Library projects like this ideally should use prefixed variables, e.g. MIMALLOC_SECURE rather than SECURE, so that amalgamations of multiple third-party dependencies used in larger monolithic projects don't end up with name conflicts or messy configuration pages.
@daanx
Copy link
Collaborator

daanx commented Jun 22, 2019 •
edited
Loading

Great suggestion, I'll add that. I have not tried yet to build as a sub directory. Let us know if there are other problems too.

daanx added a commit that referenced this issue Jun 25, 2019
@daanx
use MI_ prefix for all options to better support subdirectory cmake, …
91cb4ce 
…issue #3
@daanx
Copy link
Collaborator

daanx commented Jun 25, 2019

Fixed it by prefixing all options with MI_

@daanx daanx closed this as completed Jun 25, 2019
@chengm349 chengm349 mentioned this issue Aug 7, 2020
Open
@romange romange mentioned this issue Oct 15, 2020
Closed
@chengm349 chengm349 mentioned this issue Mar 20, 2021
Open
@DavidWzh DavidWzh mentioned this issue Mar 30, 2022
Closed
@CPlusDave CPlusDave mentioned this issue Mar 27, 2023
Closed
@Lee-HyeongSeok Lee-HyeongSeok mentioned this issue Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmiddleditch @daanx