support aligned allocation calls with alignments < pointer size #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdmoss
approved these changes
May 18, 2020
adamdmoss
reviewed
May 18, 2020
|
|
||
| // if the passed alignment is too small, correct it upwards to the minimal internal required alignment | ||
| // fixes issues in user code calling aligned variants for types with small alignment requirements below pointer alignment | ||
| alignment = alignment < sizeof(void*) ? sizeof(void*) : alignment; |
There was a problem hiding this comment.
I think this should be below the if()s below which check that we were fed with a non-0 power-of-two first, before alignment is changed. Those requirements are sane.
adamdmoss
suggested changes
May 18, 2020
needed for e.g. code bases like LLVM
|
I updated the commit with your proposed change. |
daanx
added a commit
that referenced
this pull request
May 18, 2020
|
Thanks for sending a PR! We should fix this -- however, I think just weakening the assertion is enough. With the check if (mi_unlikely(alignment==0 || !_mi_is_power_of_two(alignment))) return NULL;we already check for powers-of-two which should satisfy the requirements. There is no need to round up the alignment itself I think since any allocation will do that automatically (as all blocks are at least |
|
The assertions got relaxed, that did solve this issue, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #245
needed for e.g. code bases like LLVM