FEAT: Adding fetchval() in cursor class #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargsaumya
approved these changes
Aug 20, 2025
sumitmsft
reviewed
Aug 24, 2025
sumitmsft
requested changes
Aug 24, 2025
|
@sumitmsft Comments are resolved please approve |
sumitmsft
approved these changes
Aug 26, 2025
### Work Item / Issue Reference <!-- IMPORTANT: Please follow the PR template guidelines below. For mssql-python maintainers: Insert your ADO Work Item ID below (e.g. AB#37452) For external contributors: Insert Github Issue number below (e.g. #149) Only one reference is required - either GitHub issue OR ADO Work Item. --> <!-- mssql-python maintainers: ADO Work Item --> > [AB#34922](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/34922) > [AB#34923](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/34923) ------------------------------------------------------------------- ### Summary This pull request adds two convenience methods to the `Cursor` class in `mssql_python/cursor.py`, making it easier to manage transactions directly from the cursor object without needing to access the underlying connection. This improves usability for developers working with the cursor API. Transaction management enhancements: * Added a `commit` method to the `Cursor` class, allowing users to commit transactions directly from the cursor. This delegates to the underlying connection's `commit` method and provides error handling if the cursor is closed. * Added a `rollback` method to the `Cursor` class, allowing users to roll back transactions directly from the cursor. This delegates to the underlying connection's `rollback` method and provides error handling if the cursor is closed. --------- Co-authored-by: Jahnvi Thakkar <[email protected]>
github-actions
bot
added
pr-size: large
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request introduces a new convenience method,
fetchval, to thecursor.pymodule, designed to simplify retrieval of single values from SQL queries. Comprehensive tests have been added to ensure its correctness, robustness, and compatibility with various SQL scenarios and data types.Addition of
fetchvalmethod:fetchvalto theCursorclass inmssql_python/cursor.py, allowing users to easily fetch the first column of the first row from a query result. This is especially useful for aggregate queries or scalar selects and supports method chaining.Testing and validation of
fetchval:tests/test_004_cursor.pyto validatefetchvalfor basic functionality, multiple data types, NULL values, empty results, multiple columns/rows, aggregate functions, method chaining, closed cursor behavior, rownumber tracking, error scenarios, and common performance patterns.These changes make it easier and safer for users to retrieve single values from queries, improving developer experience and reliability.