Skip to content

question: supported nodejs versions #557

Closed
@jjangga0214

Description

@jjangga0214

Hi!

Thanks for this project :)

May I ask which nodejs versions node-pty supports?
(node-pty's package.json does not have engines field.)

For example, I saw some (closed) issues saying like "node 17 is not supported", or "installation failed in node 15".

I want to use node-pty in my open-source project.
But the project should support every recent nodejs versions.
(e.g. node>=16 : 16.x, 17.x, 18.x, 19.x, 20.x)

What's more, once a new nodejs version is released(e.g. 21.x(future)), my package should become ready for the runtime as soon as possible.

Would it be possible?

Thanks!

Activity

changed the title [-]question[/-] [+]question: supported nodejs version[/+] on Aug 25, 2022
changed the title [-]question: supported nodejs version[/-] [+]question: supported nodejs versions[/+] on Aug 25, 2022
z3bra5hax

z3bra5hax commented on Aug 28, 2022

@z3bra5hax

This is silly. LTS (eg 16.x, 18.x, 20.x) within a reasonable timeframe of their release is a fair request/assumption as long as this is considered an active project however attempting to support every release in between would slow down bug resolution and development too much. This is non-revenue-generating project for Microsoft so let's dial down our expectations on bleeding edge releases...

jjangga0214

jjangga0214 commented on Aug 29, 2022

@jjangga0214
Author

@z3bra5hax Then does node-pty support every nodejs LTS currently?
For future LTS (e.g. 22.x), once the new LTS releases, how rapidly would node-pty start supporting it?

Thanks.

daniel-brenot

daniel-brenot commented on Nov 14, 2022

@daniel-brenot
Contributor

@z3bra5hax Then does node-pty support every nodejs LTS currently? For future LTS (e.g. 22.x), once the new LTS releases, how rapidly would node-pty start supporting it?

Thanks.

The project will support LTS when it is updated to do so. This project isn't specifically a high priority from microsofts perspective I imagine, so it relies on FOSS developers to add support for LTS versions. I am currently working on support, but there is no specific date for when that may be done(could be a month, could be years).

Tyriar

Tyriar commented on Nov 30, 2022

@Tyriar
Member

This project isn't specifically a high priority from microsofts perspective I imagine

This is true, currently we support whatever node.js version VS Code's Electron is on which is currently 16 (soon to be updated). I agree this is suboptimal, but I'm also busy maintaining xterm.js and the terminal and many other features in vscode. To add to this, I'm admittedly not that great with C++ so the amount of effort it takes me to review changes is much higher.

The readme says Node 12+ which is inaccurate so I'll update that to reflect the current situation.

added a commit that references this issue on Nov 30, 2022
3e8f6e0
kkocdko

kkocdko commented on Dec 6, 2023

@kkocdko
Contributor

The #644 will make this project support from node 16 to 21, you can download & replace to test, see the message in that PR.

added a commit that references this issue on Feb 25, 2025
8ac4ff7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @Tyriar@daniel-brenot@jjangga0214@kkocdko@z3bra5hax

      Issue actions

        question: supported nodejs versions · Issue #557 · microsoft/node-pty