Skip to content

Fix cibuild #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2021
Merged

Fix cibuild #29

merged 4 commits into from
Sep 29, 2021

Conversation

underchemist
Copy link
Contributor

@underchemist underchemist commented Sep 27, 2021

Description

Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #31

  • Updates scripts/cibuild to install mypy as a dep before running
  • Adds pull_request as an event for .github/worfklows/ci-test.yml, enabling PRs from forked repositories to have workflows run as a check

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Instructions

run scripts/cibuild in a fresh virtual environment will install required deps

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@underchemist underchemist changed the title install mypy as dependency Fix cibuild Sep 27, 2021
@underchemist underchemist marked this pull request as ready for review September 28, 2021 16:35
@JBurkinshaw JBurkinshaw merged commit 5924ce9 into microsoft:main Sep 29, 2021
@underchemist underchemist mentioned this pull request Sep 30, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflows run, but do not appear in pull request from forked repository
2 participants