This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Remove use of batch in NodeMessages
#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
changed the title
batch in NodeMessages
chkeita
approved these changes
Oct 1, 2020
anshuman-goel
pushed a commit
to anshuman-goel/onefuzz
that referenced
this pull request
Oct 1, 2020
anshuman-goel
added a commit
to anshuman-goel/onefuzz
that referenced
this pull request
Oct 6, 2020
* newer onefuzz type * update to types * scaling * optional region * region as optional * pool as mandatory * cap case * newer changes * idk * af errors * pool debugging * region cap case * task state * Update `can_schedule` check to support node reimaging (microsoft#35) - Include version in `can_schedule` check, expect rich response - Check if work can be scheduled before claiming - If work is stopped, claim and drop it - If node is outdated, don't claim work * Refactor internal node event schemas (microsoft#29) * use sccache more consistently (microsoft#47) - Uses actions/cache via `src/ci/rust-prereqs.sh` to cache installing multiple rust prereqs including `cargo-audit` and `sccache` - Uses actions/cache to cache `src/agent/target` and `src/proxy-manager/target` Co-authored-by: Brian Caswell <[email protected]> * add end-to-end integration testing of fuzzing pipelines (microsoft#46) * re-add black to lint stages (microsoft#45) * fix formatting (microsoft#55) * Example sdk in azure functions (microsoft#56) * Adding node assignment to the task entity (microsoft#54) * Link VMSS nodes and tasks when setting up (microsoft#43) Add a (backwards-compatible) data field to node state update events. Use this to link nodes and tasks as soon as the tasks have been claimed. Add a new task-level `setting_up` state to encode this. * set more detailed version information during builds (microsoft#58) * Using a clean flag (microsoft#59) Locally adding `--clean` to the command helps in making a exe w/o caching. * Remove use of `batch` in NodeMessages (microsoft#60) * make version.localchanges match API logic (microsoft#62) * Set log levels in Azure Functions by hand for 3rd party libraries (microsoft#63) * use sc.exe instead of Set-Content (microsoft#67) * move to warning (microsoft#66) * slim down msg (microsoft#65) * only set stating to stopping (microsoft#64) * setting a default * reversing things * agent comment * debugging * scaling down * fixing resizes * Build 1.1.0 (microsoft#99) * Update CURRENT_VERSION (microsoft#104) * newer changes * api fix * removing onefuzztypes * linter errors * syntax error * sorting imports * linter * linter * linting fixes * linting fixes * import sort * linting fixes * linting fixes * fixes * removing non needed changes * model remove non needed changes Co-authored-by: Joe Ranweiler <[email protected]> Co-authored-by: bmc-msft <[email protected]> Co-authored-by: Brian Caswell <[email protected]> Co-authored-by: Cheick Keita <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes
NodeMessage.delete_messagesincorrectly usingbatch.Info on Pull Request
Updates the call to batch to use it like a context manager, per TableService docs
In addition, the ORM layer auto-maps contextual types, like UUIDs to strs for primary & row keys. Until we add 'batch' to ORM.py, we should just iterate over the items directly.
Validation Steps Performed
In the post 1.0.0 builds, nodes should no longer generate the following exception as they connect in:
Exception: AttributeError: '_GeneratorContextManager' object has no attribute 'delete_entity'