Skip to content

[INTERNAL](typings) Use typing.Optional instead of typing.Union[type,NoneType] #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kumaraditya303 opened this issue Feb 14, 2021 · 1 comment
Closed

[INTERNAL](typings) Use typing.Optional instead of typing.Union[type,NoneType] #507

kumaraditya303 opened this issue Feb 14, 2021 · 1 comment

Comments

@kumaraditya303
Copy link
Contributor

Python's typing module has a dedicated Optional type for nullable types but in the playwright docs, typing.Union is being used and can be confusing for the users.

Solution:
Replace all occurrences of typing.Union with typing.Optional. @mxschmitt @pavelfeldman
@kumaraditya303 kumaraditya303 mentioned this issue Feb 14, 2021
Closed
@pavelfeldman
Copy link
Member

I think 3.9 did it for us.

@kumaraditya303 kumaraditya303 mentioned this issue May 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavelfeldman @kumaraditya303