Skip to content

test: skip broken FF nav test #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022
Merged

test: skip broken FF nav test #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/async/test_har.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
from pathlib import Path

import pytest
from flaky import flaky

from playwright.async_api import Browser, BrowserContext, Error, Page, Route, expect
from tests.server import Server
Expand Down Expand Up @@ -437,7 +436,9 @@ async def test_should_go_back_to_redirected_navigation(
assert await page.evaluate("window.location.href") == "https://www.theverge.com/"


@flaky(max_runs=5) # Flaky upstream
@pytest.mark.skip_browser(
"firefox"
) # skipped upstream (https://github.com/microsoft/playwright/blob/6a8d835145e2f4002ee00b67a80a1f70af956703/tests/library/browsercontext-har.spec.ts#L214)
async def test_should_go_forward_to_redirected_navigation(
context: BrowserContext, server: Server, assetdir: Path
) -> None:
Expand Down
5 changes: 3 additions & 2 deletions tests/sync/test_har.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
from typing import Any, cast

import pytest
from flaky import flaky

from playwright.sync_api import Browser, BrowserContext, Error, Page, Route, expect
from tests.server import Server
Expand Down Expand Up @@ -374,7 +373,9 @@ def test_should_go_back_to_redirected_navigation(
assert page.evaluate("window.location.href") == "https://www.theverge.com/"


@flaky(max_runs=5) # Flaky upstream
@pytest.mark.skip_browser(
"firefox"
) # skipped upstream (https://github.com/microsoft/playwright/blob/6a8d835145e2f4002ee00b67a80a1f70af956703/tests/library/browsercontext-har.spec.ts#L214)
def test_should_go_forward_to_redirected_navigation(
context: BrowserContext, server: Server, assetdir: Path
) -> None:
Expand Down