chore: constrain Pattern type #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#1415. NB: Using bytes in patterns with our code will currently explode, so this type constrains to hint to users to use str patterns: ```py await expect(page).to_have_url(re.compile(r".*/grid\.html")) await expect(page).to_have_url(re.compile(rb".*/grid\.html")) ``` This change opts to constrain the type rather than allow for bytes, too.
mxschmitt
reviewed
Jul 19, 2022
mxschmitt
approved these changes
Jul 19, 2022
|
Cool, just wondering why you use a custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1415.
Most of this change was generated. The actual changed code (aside from find and replace) is in
//scripts/documentation_provider.py.NB: Using bytes in patterns with our code will currently explode, so
this constrains to hint to users to use str patterns:
This change opts to constrain the type rather than allow for bytes, too. If a user wants to use bytes, they can encode/decode explicitly.