Skip to content

Fix typos #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Fix typos #1482

merged 3 commits into from
Aug 12, 2022

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Aug 6, 2022

Found using command below:

codespell . -S *.js,*.ts,./playwright,./driver,./.eggs  -L complies,datas,keypair

Found using command below:

    codespell . -S *.js,*.ts,./playwright,./driver,./.eggs  -L complies,datas,keypair
@rwoll
Copy link
Member

rwoll commented Aug 9, 2022

Thanks for the PR. The errors in the files under _generated come from upstream (https://github.com/microsoft/playwright/tree/main/docs/src). Do you want to fix them there and then we can see what's left here?

@kianmeng
Copy link
Contributor Author

kianmeng commented Aug 9, 2022

Thanks for the PR. The errors in the files under _generated come from upstream (https://github.com/microsoft/playwright/tree/main/docs/src). Do you want to fix them there and then we can see what's left here?

Noted. See microsoft/playwright#16370.

@rwoll
Copy link
Member

rwoll commented Aug 9, 2022

Thanks! Once #1485 lands, you can rebase on that.

@rwoll rwoll merged commit 921f7d8 into microsoft:main Aug 12, 2022
@rwoll
Copy link
Member

rwoll commented Aug 12, 2022

Landed! Thanks @kianmeng

@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants