Skip to content

pre-commit version upgrades #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2022
Merged

pre-commit version upgrades #1483

merged 2 commits into from
Aug 10, 2022

Conversation

symonk
Copy link
Contributor

@symonk symonk commented Aug 7, 2022

Hi, small patch to bump pre-commit hook versions and silence the current mypy complaints about the sync api base.

Thanks

@ghost
Copy link

ghost commented Aug 7, 2022

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ symonk sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@rwoll
Copy link
Member

rwoll commented Aug 9, 2022

Thanks—I've triggered the CI to run and check things are working as expected.

@rwoll
Copy link
Member

rwoll commented Aug 9, 2022

It looks like there's a new mypy error showing up in the Lint job:

scripts/documentation_provider.py:208: error: Assignment expressions are only supported in Python 3.8 and greater

I don't think this is related to your change, since it also shows up in other PRs from today. I cannot re-produce the error locally (or in a fresh GitHub Codespace). @mxschmitt any ideas? Seems like it's an FP

@rwoll rwoll merged commit 4c4e13c into microsoft:main Aug 10, 2022
@symonk symonk deleted the update-pre-commit-versions branch August 10, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants