Skip to content

fix(assertions): allow tuple as valid input type for expected text values #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix(assertions): allow tuple as valid input type for expected text values #2723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright/_impl/_assertions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,7 @@ def to_expected_text_values(
ignoreCase: Optional[bool] = None,
) -> Sequence[ExpectedTextValue]:
out: List[ExpectedTextValue] = []
assert isinstance(items, list)
assert isinstance(items, (list, tuple))
for item in items:
if isinstance(item, str):
o = ExpectedTextValue(
Expand Down
4 changes: 4 additions & 0 deletions tests/async/test_assertions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,10 @@ async def test_assertions_locator_to_have_text(page: Page, server: Server) -> No
await expect(page.locator("div")).to_have_text(
["Text 1", re.compile(r"Text \d+a")]
)
# Should work with a tuple
await expect(page.locator("div")).to_have_text(
("Text 1", re.compile(r"Text \d+a"))
)


@pytest.mark.parametrize(
Expand Down
Loading