Skip to content

chore: install browsers deps using cli #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2021
Merged

chore: install browsers deps using cli #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: microsoft/playwright-github-action@v1
- name: Set up Python
uses: actions/setup-python@v2
with:
Expand All @@ -26,8 +25,8 @@ jobs:
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
- name: Build package
run: python setup.py bdist_wheel
python setup.py bdist_wheel
python -m playwright install-deps
- name: Install browsers
run: python -m playwright install
- name: Lint
Expand Down Expand Up @@ -74,18 +73,17 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- uses: microsoft/playwright-github-action@v1
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip wheel
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
- name: Build package
run: python setup.py bdist_wheel
python setup.py bdist_wheel
python -m playwright install-deps
- name: Install browsers
run: python -m playwright install
- name: Common Tests
Expand Down Expand Up @@ -123,18 +121,17 @@ jobs:
shell: powershell
run: Install-WindowsFeature Server-Media-Foundation
- uses: actions/checkout@v2
- uses: microsoft/playwright-github-action@v1
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.8
- name: Install dependencies
run: |
python -m pip install --upgrade pip wheel
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
- name: Build package
run: python setup.py bdist_wheel
python setup.py bdist_wheel
python -m playwright install-deps
- name: Install ffmpeg
run: python -m playwright install ffmpeg
- name: Common Tests
Expand All @@ -158,7 +155,6 @@ jobs:
timeout-minutes: 30
steps:
- uses: actions/checkout@v2
- uses: microsoft/playwright-github-action@v1
- name: Set up Node.js
uses: actions/setup-node@v1
with:
Expand All @@ -172,7 +168,7 @@ jobs:
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
- name: Build package
run: python setup.py bdist_wheel
python setup.py bdist_wheel
python -m playwright install-deps
- name: Test package installation
run: bash buildbots/test-package-installations.sh
5 changes: 2 additions & 3 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: microsoft/playwright-github-action@v1
- name: Set up Node.js
uses: actions/setup-node@v1
with:
Expand All @@ -21,8 +20,8 @@ jobs:
python -m pip install --upgrade pip
pip install -r local-requirements.txt
pip install -e .
- name: Build package
run: python setup.py bdist_wheel
python setup.py bdist_wheel
python -m playwright install-deps
- name: Publish package
env:
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
Expand Down