Skip to content

chore: roll to Playwright 1.15.2-1633455481000 #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions playwright/_impl/_network.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,7 @@ async def header_value(self, name: str) -> Optional[str]:
async def _actual_headers(self) -> "RawHeaders":
if not self._all_headers_future:
self._all_headers_future = asyncio.Future()
response = await self.response()
if not response:
return self._provisional_headers
headers = await response._channel.send("rawRequestHeaders")
headers = await self._channel.send("rawRequestHeaders")
self._all_headers_future.set_result(RawHeaders(headers))
return await self._all_headers_future

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
InWheel = None
from wheel.bdist_wheel import bdist_wheel as BDistWheelCommand

driver_version = "1.15.0-1633020276000"
driver_version = "1.15.2-1633455481000"


def extractall(zip: zipfile.ZipFile, path: str) -> None:
Expand Down
2 changes: 2 additions & 0 deletions tests/async/test_network.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@

async def test_request_fulfill(page, server):
async def handle_request(route: Route, request: Request):
headers = await route.request.all_headers()
assert headers["accept"]
assert route.request == request
assert repr(route) == f"<Route request={route.request}>"
assert "empty.html" in request.url
Expand Down