feat(codegen): pytest support in codegen #13746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposal to add support for pytest in the code generator
|
I'm supportive for adding this kind of the codegen. I would not copy and paste though - take a look at a sibling |
|
@pavelfeldman I updated in 56ebcaf based on your recommendation. Should I also add tests? The Javascript test does not have this either. |
Take a look at this file - it is testing the javascript implementation. |
dgozman
reviewed
May 2, 2022
mxschmitt
approved these changes
May 4, 2022
| constructor(isAsync: boolean) { | ||
| this.id = isAsync ? 'python-async' : 'python'; | ||
| this.fileName = isAsync ? 'Python Async' : 'Python'; | ||
| constructor(isAsync: boolean, isTest: boolean) { |
There was a problem hiding this comment.
Suggested change
| constructor(isAsync: boolean, isTest: boolean) { | |
| constructor(isAsync: boolean, isPyTest: boolean) { |
| this._isAsync = isAsync; | ||
| this._isTest = isTest; |
There was a problem hiding this comment.
Suggested change
| this._isTest = isTest; | |
| this._isPyTest = isPyTest; |
Comment on lines
+197
to
+199
| if (this._isTest) { | ||
| return ''; | ||
| } else if (this._isAsync) { |
There was a problem hiding this comment.
Suggested change
| if (this._isTest) { | |
| return ''; | |
| } else if (this._isAsync) { | |
| if (this._isTest) | |
| return ''; | |
| if (this._isAsync) { |
| }); | ||
|
|
||
| test('should save the codegen output to a file if specified', async ({ runCLI }, testInfo) => { | ||
| const tmpFile = testInfo.outputPath('script.js'); |
There was a problem hiding this comment.
Suggested change
| const tmpFile = testInfo.outputPath('script.js'); | |
| const tmpFile = testInfo.outputPath('test_foo.py'); |
nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add support for
pytestin the code generatorNOTE:
Everything here are roughly a copy-pasted from thePythonLanguageGenerator. Hope it gains approval from community.so this can be removed/turned off([FEATURE] Expose Playwright async/await flavor playwright-pytest#74)