Skip to content

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jul 2, 2020

We have tests that will never pass, currently marked as fail(true) - remove them.
Update all the rest to use non-deprecated {httpCredentials} option instead of setHTTPCredentials(), leaving just one to test the latter.

@aslushnikov
Copy link
Contributor

  • shall we still test these at least at some extend since we do ship them to users? The method might have shortcomings, but be should keep it tested as long as we ship it
  • how come coverage test didn't fail miserably for this PR?!

@dgozman dgozman changed the title test: stop testing deprecated method BrowserContext.setHTTPCredentials test: update http credentials tests Jul 6, 2020
@dgozman
Copy link
Contributor Author

dgozman commented Jul 6, 2020

  • shall we still test these at least at some extend since we do ship them to users? The method might have shortcomings, but be should keep it tested as long as we ship it

Yep, I left one test for this method.

  • how come coverage test didn't fail miserably for this PR?!

Good point. Fixed, although our coverage always breaks. We need a better solution.

@aslushnikov
Copy link
Contributor

Note: firefox linux coverage now fails

@dgozman dgozman merged commit ac2185a into microsoft:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants