fix(recorder): align apiName with the real one #33567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
approved these changes
Nov 13, 2024
Otherwise, we see `page.expect()` in the call log. Additionally, align `assertingSnapshot` mode with all other asserting modes.
dgozman
force-pushed
the
recorder-fix-api-name
branch
from
7fe650d to
31ce711
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 flaky36831 passed, 678 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we see
page.expect()in the call log. Additionally, alignassertingSnapshotmode with all other asserting modes.