chore(console): expose window.playwright by default #36921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
force-pushed
the
default-expose-window-playwright
branch
from
aaa716f to
afcb0ad
Compare
mxschmitt
reviewed
Aug 5, 2025
dgozman
reviewed
Aug 5, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
i don't get it. why is it all red, but not locally? |
I can't see why either. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
commented
Aug 6, 2025
| const context = await this._context('main'); | ||
| const injectedScriptHandle = await context.injectedScript(); | ||
| return injectedScriptHandle.evaluateHandle((injectedScript, { source, arg }) => { | ||
| await injectedScriptHandle.evaluate((injectedScript, { source, arg }) => { |
There was a problem hiding this comment.
this was leaking the handle.
This comment has been minimized.
This comment has been minimized.
|
alright, tests are fixed. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Aug 6, 2025
| const injectedScriptHandle = await context.injectedScript(); | ||
| return injectedScriptHandle.evaluateHandle((injectedScript, { source, arg }) => { | ||
| await injectedScriptHandle.evaluate((injectedScript, { source, arg }) => { | ||
| return injectedScript.extend(source, arg); |
There was a problem hiding this comment.
No need to return a value here.
Test results for "tests 1"2 failed 38 flaky46558 passed, 805 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36772