fix(a11y): track inert elements as hidden #36947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"2 flaky46599 passed, 805 skipped Merge workflow run. |
dgozman
approved these changes
Aug 7, 2025
|
Hey, folks It seems this was shipped with v1.55, though the linked issue is labeled for the next version. This is probably worth mentioning in the changelog: the locators targeting elements with an |
|
thanks @Mamaduka - I'll bring it up in the team meeting later. |
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Aug 21, 2025
This reverts commit 6e3392b.
|
Reverting in #37137 |
agg23
added a commit
that referenced
this pull request
Aug 21, 2025
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Aug 22, 2025
mxschmitt
pushed a commit
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36938.
Implement the somewhat vague
inertHTML attribute spec for our accessibility tree.My interpretation is that nodes are marked hidden, equivalent to
aria-hidden, if they possess theinertattribute. This cascades to all "flat tree descendants", which are the standard descendants plus special handling for shadow DOM.Some nodes can additionally opt out (by virtue of their tag, not by specifying a property, as it is not possible to supply an explicit
falseflag toinert, just the absence of the attribute). The spec lists modaldialogs as an example of a tag that escapesinert.This opt out behavior is not supported by this PR