fix(html): don't display a chip with empty content with no projects #37153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"1 flaky46633 passed, 805 skipped Merge workflow run. |
dgozman
reviewed
Aug 25, 2025
| style?: React.CSSProperties, | ||
| }> = ({ projectNames, activeProjectName, otherLabels, useLinks, style }) => { | ||
| return (projectNames.length > 0 || otherLabels.length > 0) && <span className='label-row' style={style ?? {}}> | ||
| // We can have an empty project name if we have no projects specified in the config |
There was a problem hiding this comment.
We can also have multiple empty projects. Will this code work in such a case?
projects: [
{ name: 'chromium' },
{ /* some settings */ },
{ /* different settings */ },
{ name: 'webkit' },
]
There was a problem hiding this comment.
It functions with any project without a name.
dgozman
approved these changes
Aug 27, 2025
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37146
For some reason when we have no user specified projects, we insert a project with the empty string as its name. This was getting displayed following #36866.