fix(chromium): wait for existing pages when connecting #6511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
changed the title
yury-s
approved these changes
May 11, 2021
| // Target.setAutoAttach has a bug where it does not wait for new Targets being attached. | ||
| // However making a dummy call afterwards fixes this. | ||
| // This can be removed after https://chromium-review.googlesource.com/c/chromium/src/+/2885888 lands in stable. | ||
| await session.send('Target.getTargetInfo'); |
There was a problem hiding this comment.
We used to have code with setDiscoverTargets which did this, maybe it's easier to just revert that?
There was a problem hiding this comment.
The code with setDiscoverTargets was way more complicated had bugs in it related to connecting twice to service workers.
|
Looks like this is causing an electron test to fail. Looking into it |
JoelEinbinder
force-pushed
the
fix_attach_to_target
branch
from
bf6141e to
9273474
Compare
|
Electron had a race where it was not expecting pages to appear before the browser was finished launching. I fixed it, and a test that was relying on that behavior. This could affect user code. I don't think we have a problem, because we used |
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
May 17, 2021
This cherry-picks two PRs: - PR microsoft#6502 SHA 2ea465b - PR microsoft#6511 SHA 3bded35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/playwright-python#679