-
Notifications
You must be signed in to change notification settings - Fork 66
Features/people picker #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I notice that this component is using custom events - are these now supported for code-components? I also see that it is using the new object output types - which is cool. I did a blog post on how to set object outputs using a dynamic schema rather than a static schema as shown by this component - https://develop1.net/public/post/2022/10/25/object-outputs-in-pcf-code-components |
Awesome! Thanks for sharing the blog. Custom events are now supported, official announcement awaited. Events are yet to be exposed via property bag interface of Context Object by the Platform. |
maxRetries === 0 | ||
? //return empty result as dataset is assumed empty | ||
this.returnPeople(this.resolve, true) | ||
: setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of setTimeout seems quite fragile since it only allows 5 seconds for the suggestions to be resolved - the tag picker uses the loading and updatedProperties to trigger the suggestions resolved.
What caused you to go down this setTimeout route instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed specifically to handle Office365Users connector based scenarios. loading and updatedProperties were not sufficient enough to mark suggestions resolved. For e.g. the suggestions(dataset) received via updateView call, with loading being false and updateProperties being true is not guaranteeing the result being correct to mark as resolve. This can be replicated in tag picker too. Agree on the point that 5 secs is fragile.
It's great that custom events are supported now - when will this be announced? |
Not sure on the timeline. Yes, I think that flag will not be required. |
…powercat-code-components into features/PeoplePicker
…powercat-code-components into features/PeoplePicker
* Calendar Test Added - gitignore updated * Removed Shimmer Coverage/ Updated Test Snaps * Udpated Test for Progress Indicator * fix:(Calendar) test failing due to dependency on today's date (#30) * fix: (pivot) width in custom pages (#33) chore: (pivot) npm update - stay with pcf-scripts 1.14.2 due to webpack dependency issue * fix: auto-height in custom pages (#32) fix: onchange not fired when any outputs undefined chore: npm update and test chore: spelling mistake chore: variable names should be camelCase * Facepile component added (#35) * Facepile component added * reactdom-definition * fixing typos * Update Facepile.1033.resx Adding preview tag * Facepile propertyname changed (#48) * Features/people picker (#46) * PeoplePicker Added * Code refactor and Documentation * Updated readme, fixed typos. * refactor: code optimization-onsearch/retries * Tweaks * refactor : render - pre-selected members * Readme modified * refactor : duplicate code removed * refactor : personakey & presence type change * refactor: presence return type fix Co-authored-by: Scott Durow <[email protected]> * Searchbox (#49) * Added SearchBox * updated searchbox * added comments to index * renamed component.types.ts and updated searchbox * added tests * enhancement Co-authored-by: Denise Moran <[email protected]> * test: test modified * (People Picker) Deterministic Suggestions Resolution (#51) * fixes issue with suggestions not resolving correctly fixes other minor typos and consistency issues * fix casing on peoplepicker file Co-authored-by: Scott Durow <[email protected]> Co-authored-by: Denise Moran <[email protected]>
* Calendar Test Added - gitignore updated * Removed Shimmer Coverage/ Updated Test Snaps * Udpated Test for Progress Indicator * fix:(Calendar) test failing due to dependency on today's date (#30) * fix: (pivot) width in custom pages (#33) chore: (pivot) npm update - stay with pcf-scripts 1.14.2 due to webpack dependency issue * fix: auto-height in custom pages (#32) fix: onchange not fired when any outputs undefined chore: npm update and test chore: spelling mistake chore: variable names should be camelCase * Facepile component added (#35) * Facepile component added * reactdom-definition * fixing typos * Update Facepile.1033.resx Adding preview tag * Facepile propertyname changed (#48) * Features/people picker (#46) * PeoplePicker Added * Code refactor and Documentation * Updated readme, fixed typos. * refactor: code optimization-onsearch/retries * Tweaks * refactor : render - pre-selected members * Readme modified * refactor : duplicate code removed * refactor : personakey & presence type change * refactor: presence return type fix Co-authored-by: Scott Durow <[email protected]> * Searchbox (#49) * Added SearchBox * updated searchbox * added comments to index * renamed component.types.ts and updated searchbox * added tests * enhancement Co-authored-by: Denise Moran <[email protected]> * test: test modified * (People Picker) Deterministic Suggestions Resolution (#51) * fixes issue with suggestions not resolving correctly fixes other minor typos and consistency issues * fix casing on peoplepicker file * Searchbox - fix : custom page width (#52) * Added SearchBox * updated searchbox * added comments to index * renamed component.types.ts and updated searchbox * added tests * enhancement * removed comments from searchbox tests * fix : Addresses CustomPage Width Co-authored-by: Denise Moran <[email protected]> * October release doc updates * refactor: modified create-release-added npm ci * Update Facepile.resx remove additional tags * Searchbox (#56) * updated readme * fix: assigning class to searchbox * feature : set focus Co-authored-by: Denise Moran <[email protected]> * Creatorkit mehdis persona (#47) * Person Component * Adding missed resource properties * Various updates fixing comments from code review * Adding InitialsColors property * removing unused import and fixing readme * fix: component import fix Co-authored-by: Ramakrishnan Raman <[email protected]> * Feature/searchbox#82 (#131) * feat:#82 - completed * Feature/tooltip (#132) * Added tooltipcontext property * Updated strings * feat:icon tooltip Co-authored-by: Denise Moran <[email protected]> * feat:SubwayNav component added (#133) * feat:SubwayNav component added * feat:spinbutton (#134) * included Spinbtn directory * removing code * duplicate directory mention * adding subwaynav versioning stamp * fix:custom page width issue (#145) * feat:subwaynav showanimation property (#225) * feat:subwaynav showanimation property * updated tests * fixes microsoft/powercat-creator-kit#285 (#226) * fixes microsoft/powercat-creator-kit#316 (#228) * feat: searchbox-defaultvalue-set-option (#230) * feat: searchbox-defaultvalue-set-option * fixes calendar language support (#231) * fixes searchtext bound property (#234) * fixes searchtext bound property * updated testsnap * feat: searchbox bordercolor property (#235) --------- Co-authored-by: Scott Durow <[email protected]> Co-authored-by: Denise Moran <[email protected]> Co-authored-by: Mehdi Slaoui Andaloussi <[email protected]>
@slaouist PeoplePicker component added.