Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

PTVS-LS Integration: Fix LS hanging during file changes #501

Closed
AlexanderSher opened this issue Dec 22, 2018 · 1 comment
Closed

PTVS-LS Integration: Fix LS hanging during file changes #501

AlexanderSher opened this issue Dec 22, 2018 · 1 comment
Assignees
@AlexanderSher
Labels
bug Something isn't working

Comments

@AlexanderSher
Copy link
Contributor

No consistent repro, but has been noticed multiple times.
@AlexanderSher AlexanderSher self-assigned this Jan 3, 2019
@AlexanderSher AlexanderSher added the bug Something isn't working label Jan 3, 2019
@AlexanderSher
Copy link
Contributor Author

AlexanderSher commented Jan 3, 2019 •
edited
Loading

ProjectEntry._expectedAnalysisVersion becoming lower than ModuleAnalysis.Version and _analysisTcs never get canceled or completed. This is also reproducible in VSCode, but VSCode can cancel pending requests (so further request processing may proceed) and it never hangs the UI. VS protocol doesn't support cancellation and has sync-over-async requests that come directly from UI thread, so both LS and VS hang.

AlexanderSher added a commit to AlexanderSher/python-language-server that referenced this issue Jan 8, 2019
@AlexanderSher
- Add nuspec
0696b81 
- Fix microsoft#501: PTVS-LS Integration: Fix LS hanging during file changes
- Fix microsoft#502: PTVS-LS Integration: Add required *.py files to the vsix
AlexanderSher added a commit that referenced this issue Jan 9, 2019
@AlexanderSher
PTVS integration (#524)
13d2202 
* Clean up Completions, Find References and Hover unit tests.

* Initial commit

* CoreProduct buildable

* Product buildable except IronPython

* Move VS-specific file

* add hack to prevent True/False/None/... from being use-before-def (#464)

* Fix for extra paths inside workspace (#467)

Fix #281: Support "go to definition" for namespace packages
Fix #466: Fix "go to definition" and resolving imports

The fix is to put user search paths in front of workspace directory so that modules inside extra paths can be used as roots for packages

* Last port

* - Add nuspec
- Fix #501: PTVS-LS Integration: Fix LS hanging during file changes
- Fix #502: PTVS-LS Integration: Add required *.py files to the vsix

* Address CR comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AlexanderSher AlexanderSher

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexanderSher