Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Unconditionally reading InitializeParams #751

Closed
ryan-ph opened this issue Mar 14, 2019 · 4 comments
Closed

Unconditionally reading InitializeParams #751

ryan-ph opened this issue Mar 14, 2019 · 4 comments

Comments

@ryan-ph
Copy link

ryan-ph commented Mar 14, 2019

In the following code-snippet, the InitializeParams.initializationOptions is being unconditionally read despite it being allowed to be null, causing errors when setting this language server up with vim-lsc.

https://github.com/Microsoft/python-language-server/blob/d63a6463fb14144e390ace912f42faaeb372fc48/src/LanguageServer/Impl/Implementation/Server.cs#L100-L150

@jakebailey
Copy link
Member

At the moment, these options need to be set, otherwise the language server isn't going to be functional. Perhaps it shouldn't crash, but if you want it to work you have to specify the settings. I'm working on cleaning up the initialization and defaults (#720, #608, #678, #469), but I don't think we're going to get to a point quite yet where that value will be allowed to be null and the LS still start into a good state.

@ryan-ph
Copy link
Author

ryan-ph commented Mar 15, 2019

Is it possible to have it default to some non-null, blank object here so that it follows LSP?

@jakebailey
Copy link
Member

That's what I was saying above; we need to define defaults, but there are other configuration changes and decisions that need to happen before that is immediately possible.

@MikhailArkhipov
Copy link

Is this still applicable since items above are now closed except #469.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants