This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Allow navigation to stubs #1960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 30, 2019 12:03
This reverts commit 6109ac7.
|
Does this need a test for the linked issue? I'm surprised |
|
It is in |
|
The original issue was not on Windows, so hopefully the same behavior occurs there too. |
added 6 commits
March 26, 2020 14:34
|
This appears to break the UpdateReferencesOnEdit test. |
|
Specifically, the first |
|
Fixed, unintentional change. |
jakebailey
approved these changes
May 1, 2020
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Escape [ and ] * PR feedback * Allow navigation to stubs * Better handle stubs for compiled modules * Fix typeshed path * Partial undo * Partial undo * Undo accidental change
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Revert "Don't suppress LHS diagnostics on augmented assign" This reverts commit 6109ac7. * Escape [ and ] * PR feedback * Allow navigation to stubs * Better handle stubs for compiled modules * Fix typeshed path * Partial undo * Partial undo * Undo accidental change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No harm in showing stub for compiled code or when otherwise source is not available. Also fixes issue when documentation on
osparts was not transferred sincentorposixare not submodules ofos.Closes #1921