Several bug fixes #280
Several bug fixes #280
Conversation
- Fix issue microsoft#109: Reloading modules leaks memory - Fix issue microsoft#278: Huge memory usage when analysis 9 lines python code - Some code clean-up
|
I can confirm that this fixes #278. Nice! |
| @@ -22,16 +22,14 @@ namespace Microsoft.PythonTools.Parsing.Ast { | |||
| public class DottedName : Node { | |||
| private readonly NameExpression[] _names; | |||
|
|
|||
| public DottedName(NameExpression[] names) { | |||
| public DottedName(NameExpression[]/*!*/ names) { | |||
There was a problem hiding this comment.
What's the meaning of /*!*/ introduced in a few of these files?
There was a problem hiding this comment.
Just a comment that I've used to mark parameter that can't be null. I can add Check calls instead.
There was a problem hiding this comment.
You don't have to change it, I just hadn't seen that before and was curious. Grepping through the project shows its use a number of other times as well (so I just hadn't noticed).
There was a problem hiding this comment.
To be clear - this is just a comment. It isn't handled by any analyzers. I really expect to see non-nullable reference types in C# 8: https://github.com/dotnet/csharplang/wiki/Nullable-Reference-Types-Preview
There was a problem hiding this comment.
Yep, I know. I actually went searching to see if that feature existed yet when you mentioned it. 🙂
| } | ||
|
|
||
| public void ClearReferencedModules() { | ||
| foreach (var moduleReference in _referencedModules.Values.Distinct()) { |
There was a problem hiding this comment.
Not sure if Values can be null (when module is missing) - perhaps MaybeEnumerate?
There was a problem hiding this comment.
_referencedModules is a dictionary, it is always initialized and it is readonly.
…-server into Fix95 # Conflicts: # src/Analysis/Engine/Test/CompletionTest.cs
Several bug fixes
from ... importshows incorrect completions #95:from ... importshows incorrect completions.TryGetCompletionsInFromImportdidn't use information fromModuleInfo._referencedModules, trying to find module directly inside AST.ModuleInfo.Cleardidn't remove back references fromModuleReferenceinstancesDocumentSymboltree.Server.ToDocumentSymbolsusesDictionary<IMemberResult, List<IMemberResult>>to make a tree, andMemberResult'sGetHashCodeandEqualsdidn't take care of the scope. As a result, all results with equal parent name were collapsed into one level, which created a loop in a resulting tree where Json.Net has been hanging.