This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fixes NullReferenceException when trying to access InstanceInfo.InstanceAttributes #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostmsu
force-pushed
the
fixes/InstanceAttributesNull
branch
from
b7ab1ce to
fdc8eca
Compare
| IReadOnlyDictionary<string, IVariableDefinition> IInstanceInfo.InstanceAttributes | ||
| => InstanceAttributes.ToDictionary(kvp => kvp.Key, kvp => kvp.Value as IVariableDefinition); | ||
| => _instanceAttrs?.ToDictionary(kvp => kvp.Key, kvp => kvp.Value as IVariableDefinition); |
There was a problem hiding this comment.
Probably should return empty dictionary rather than null. Try _instanceAttrs.MaybeEnumerate().ToDictionary(...)
lostmsu
force-pushed
the
fixes/InstanceAttributesNull
branch
from
fdc8eca to
7816414
Compare
MikhailArkhipov
approved these changes
Oct 19, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
…esNull Fixes NullReferenceException when trying to access InstanceInfo.InstanceAttributes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subj.
When there are no instance attributes,
InstanceAttributesshould returnnullor an empty dictionary. In this changeI choose to returnwe agreed on an empty dictionarynull