Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Preprocess search paths #966

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Conversation

jakebailey
Copy link
Member

Fixes #849.

This does some preprocessing of searchPaths, removing redundant entries and rooting relative paths.

@jakebailey
Copy link
Member Author

An option question on this: Should I be also filtering out paths that are just /? For example, see #849, where we end up with a search path of /. This, to me, seems like an extension bug I don't really want to work around (lest the language server gets run in something like a docker container or CI where / actually contains something), but wouldn't be difficult to ignore.

@jakebailey jakebailey merged commit cc7d4f7 into microsoft:master Apr 16, 2019
@jakebailey jakebailey deleted the clean-search-paths branch April 16, 2019 18:47
jakebailey added a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019
* preprocess search paths

* remove wait for debugger

* ignore /
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language Server does not work with PYTHONPATH=./
2 participants