Skip to content

Remove bogus statements from type stubs #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Jan 29, 2025

These statements don't make sense in stubs, and prevent tools like https://github.com/JelleZijlstra/stubdefaulter from working

After this PR, running stubdefaulter --packages stubs would work.

@Avasam Avasam changed the title Remove bogus conditions from type stubs Remove statements from type stubs Jan 29, 2025
@Avasam Avasam force-pushed the Remove-bogus-conditions-from-type-stubs branch from fa0dabf to 65df11b Compare January 29, 2025 01:17
@Avasam Avasam changed the title Remove statements from type stubs Remove bogus statements from type stubs Jan 30, 2025
@debonte debonte merged commit a721313 into microsoft:main Mar 14, 2025
1 check passed
@Avasam Avasam deleted the Remove-bogus-conditions-from-type-stubs branch March 15, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants