Skip to content

Move requirements to dev dependency group and consistent dep version in tests #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Mar 15, 2025

Must wait for the next release of pip that will support PEP 735 thanks to pypa/pip#13065

  • The Ruff version is now obtained automatically from the listed requirements, both in CI and locally.
  • "hygiene" and "tests" still have different sets of dependencies
  • Running pip install --group dev or uv sync will install all dev-dependencies

@Avasam Avasam force-pushed the dev-dependency-group-and-consistent-dep-version-in-tests branch from 2e69d4b to 71e1804 Compare March 15, 2025 16:41
@Avasam Avasam marked this pull request as ready for review May 5, 2025 19:54
@Avasam
Copy link
Contributor Author

Avasam commented May 5, 2025

"pyright",

# Typed libraries and stubs
"matplotlib >=3.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a new issue, but I'm curious why we're testing against matplotlib >=3.8 since those are the versions for which matplotlib ships their own stubs. 3.8.0 shipped back in September 2023. I wonder when we'll be comfortable removing our matplotlib stubs.

Copy link
Contributor Author

@Avasam Avasam May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimage, sklearn and sympy all reference matplotlib !
Here it's considered "a typed library external to "python-type-stubs".
You want to test against matplotlib >=3.8 specifically because it's the version that provides their own types.

So once matplotlib stubs are removed from this repo, this line should stay.

@debonte debonte merged commit d7d8ff9 into microsoft:main May 5, 2025
3 checks passed
@Avasam Avasam deleted the dev-dependency-group-and-consistent-dep-version-in-tests branch May 5, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants