Skip to content

mypy: Fix all var-annotated, return, no-redef + list scope of other errors #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025
Merged

mypy: Fix all var-annotated, return, no-redef + list scope of other errors #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e131ec7
Fix many small mypy issues
Avasam May 3, 2025
aebb775
Merge branch 'main' into Fix-many-small-mypy-issues
debonte May 5, 2025
5e70fee
Merge branch 'main' into Fix-many-small-mypy-issues
debonte May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,10 @@ disable_error_code = [
# Not all imports in these stubs are gonna be typed
"import-untyped",
# TODO
"assert-type",
"assignment",
"attr-defined",
"misc",
"no-redef",
"override",
"return",
"valid-type",
"var-annotated",
"valid-type", # 967 errors in 115 files
"override", # 790 errors in 220 files
"assignment", # 773 errors in 172 files
"misc", # 692 errors in 132 files
"attr-defined", # 202 errors in 75 files
"assert-type", # 6 errors in 1 file
]
5 changes: 0 additions & 5 deletions stubs/matplotlib/ft2font.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Python: 3.8.8 (tags/v3.8.8:024d805, Feb 19 2021, 13:18:16) [MSC v.1928 64 bit (AMD64)]
# Library: matplotlib, version: 3.4.0
# Module: matplotlib.ft2font, version: unspecified
import builtins as _mod_builtins
import typing

BOLD: int
Expand Down Expand Up @@ -123,11 +122,7 @@ MULTIPLE_MASTERS: int
SCALABLE: int
SFNT: int
VERTICAL: int
__doc__: typing.Any
__file__: str
__freetype_build_type__: str
__freetype_version__: str
__name__: str
__package__: str

def __getattr__(name) -> typing.Any: ...
2 changes: 1 addition & 1 deletion stubs/networkx/classes/ordered.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ from .graph import Graph
from .multidigraph import MultiDiGraph
from .multigraph import MultiGraph

__all__ = []
__all__: list[str] = []

class OrderedGraph(Graph):
node_dict_factory = ...
Expand Down
4 changes: 1 addition & 3 deletions stubs/sympy-stubs/core/cache.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,4 @@ SYMPY_CACHE_SIZE = ...

def cacheit(func: _CallableT) -> _CallableT: ...
def cached_property(func) -> property: ...
def lazy_function(module: str, name: str) -> Callable:
class LazyFunctionMeta(type): ...
class LazyFunction(metaclass=LazyFunctionMeta): ...
def lazy_function(module: str, name: str) -> Callable: ...
2 changes: 0 additions & 2 deletions stubs/vispy/ext/cocoapy.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,8 +364,6 @@ kCGImageAlphaNoneSkipLast: int = ...
kCGImageAlphaNoneSkipFirst: int = ...
kCGImageAlphaOnly: int = ...

kCGImageAlphaPremultipliedLast: int = ...

kCGBitmapAlphaInfoMask: int = ...
kCGBitmapFloatComponents = ...

Expand Down