Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Cgranade/lock nightly #1069

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Cgranade/lock nightly #1069

merged 3 commits into from
Aug 3, 2022

Conversation

cgranade
Copy link
Contributor

@cgranade cgranade commented Aug 3, 2022

This PR locks the version of the nightly Rust toolchain used to build the open systems simulator, preventing upstream changes from breaking builds until we are ready to upgrade to more recent nightly builds. In particular, the removal of std::error::Error::backtrace from the #![feature(backtrace)] feature caused a recent breakage, such that we can restore PR by locking before rust-lang/rust#99431 landed — it would be good to update to use the new provider API instead, but for now, locking the toolchain allows us to restore the build.

@cgranade cgranade requested a review from swernli as a code owner August 3, 2022 16:56
@cgranade cgranade enabled auto-merge (squash) August 3, 2022 16:56
@@ -0,0 +1 @@
nightly-2022-08-01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often will we need to update this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, we don't need to on any fixed schedule — old nightly builds persist and are valid, but will not include bugfixes from future nightlies. From that perspective, it's good practice to update as part of the regular maintenance of the project. Since we use a minimal number of unstable features (specifically, only backtrace), the cost to updating is very minimal — everything not gated on a feature attribute is still stable and subject to API stability rules.

@cgranade
Copy link
Contributor Author

cgranade commented Aug 3, 2022

Apologies, it looks like I accidentally included #1058 in this PR as well; since that has been previously approved, I'll leave it in for now unless there's an objection.

@cgranade cgranade merged commit f620469 into main Aug 3, 2022
@cgranade cgranade deleted the cgranade/lock-nightly branch August 3, 2022 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants