Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Updated QirRuntime/README.md, build/test instructions #591

Merged
merged 8 commits into from
Mar 27, 2021
Merged

Updated QirRuntime/README.md, build/test instructions #591

merged 8 commits into from
Mar 27, 2021

Conversation

kuzminrobin
Copy link
Contributor

No description provided.

@kuzminrobin kuzminrobin force-pushed the kuzminrobin/updReadMe branch from ef58fff to 21934b3 Compare March 26, 2021 01:16
@kuzminrobin kuzminrobin marked this pull request as ready for review March 26, 2021 01:18
bettinaheim
bettinaheim reviewed Mar 26, 2021
View reviewed changes
Copy link
Contributor

@bettinaheim bettinaheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried to follow the instructions just yet, but will do so a bit later. For now just a few comments reading through it.

cgranade
cgranade reviewed Mar 26, 2021
View reviewed changes
swernli
swernli reviewed Mar 26, 2021
View reviewed changes
swernli
swernli reviewed Mar 26, 2021
View reviewed changes
swernli
swernli reviewed Mar 26, 2021
View reviewed changes
swernli
swernli reviewed Mar 26, 2021
View reviewed changes
@kuzminrobin kuzminrobin mentioned this pull request Mar 26, 2021
Closed
@kuzminrobin
Copy link
Contributor Author

All the feedback has been addressed. Please review.

@kuzminrobin kuzminrobin self-assigned this Mar 26, 2021
@kuzminrobin kuzminrobin enabled auto-merge (squash) March 26, 2021 15:08
swernli
swernli approved these changes Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last removal, and I think these updates are good to go. Thanks for taking the time to do this!

@kuzminrobin kuzminrobin force-pushed the kuzminrobin/updReadMe branch from 238975c to f5abf72 Compare March 26, 2021 20:32
@kuzminrobin kuzminrobin merged commit 47237ce into main Mar 27, 2021
@kuzminrobin kuzminrobin deleted the kuzminrobin/updReadMe branch March 27, 2021 00:24
@kuzminrobin kuzminrobin linked an issue Mar 27, 2021 that may be closed by this pull request
Update qsharp-runtime/src/QirRuntime/README.md #583
Closed
DmitryVasilevsky
DmitryVasilevsky reviewed Mar 29, 2021
View reviewed changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgranade cgranade cgranade left review comments

@bettinaheim bettinaheim bettinaheim left review comments

@DmitryVasilevsky DmitryVasilevsky DmitryVasilevsky left review comments

@swernli swernli swernli approved these changes

Assignees

@kuzminrobin kuzminrobin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update qsharp-runtime/src/QirRuntime/README.md
5 participants
@kuzminrobin @cgranade @swernli @bettinaheim @DmitryVasilevsky