This repository was archived by the owner on May 20, 2025. It is now read-only.
Place the Install button on the right side of the Update Dialog #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
itoys
approved these changes
Mar 16, 2018
There was a problem hiding this comment.
Hi @Hunter-Dolan
Thank you for contributing, that's awesome suggestion!
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We use Code Push's update dialog on several of my projects and have had great results so far. One minor point of annoyance is that the Install button is to the left of the Update Dialog when the "Ignore" option is enabled.
On most alerts, it seems common practice to keep the cancel/ignore button to the left and the "confirm" button to the right (Enable Push Notifications, Location Services, etc). During beta testing we saw several people accidentally ignore the update because of this.
This pull request addresses this issue by swapping the order of the two buttons.