This repository was archived by the owner on May 20, 2025. It is now read-only.
Fix usage of removed method AppState.removeEventListener #2385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2022
trcoffman
force-pushed
the
fixRemoveEventListenerUndefined
branch
from
f261e34 to
9c64771
Compare
thewulf7
approved these changes
Dec 12, 2022
AppState.removeEventListener was removed in react-native 0.70, after being deprecated for over a year. Anybody using react-native 0.70 will experience an unhandled TypeError when trying to invoke removeEventListener. Replace the usage of removeEventListener with the `remove()` method on the subscription returned by addEventListener. Stop reassigning the resumeListener argument. It's a bad practice to reassign function arguments, and it is common to have an eslint rule to block this. Rename the argument to retryOnAppResume so that when we create resumeListener, there is no reassignment of a function argument.
trcoffman
force-pushed
the
fixRemoveEventListenerUndefined
branch
from
9c64771 to
b2a8d45
Compare
cc-matthias-m
pushed a commit
to ClubConnect/react-native-code-push
that referenced
this pull request
Dec 23, 2022
) AppState.removeEventListener was removed in react-native 0.70, after being deprecated for over a year. Anybody using react-native 0.70 will experience an unhandled TypeError when trying to invoke removeEventListener. Replace the usage of removeEventListener with the `remove()` method on the subscription returned by addEventListener. Stop reassigning the resumeListener argument. It's a bad practice to reassign function arguments, and it is common to have an eslint rule to block this. Rename the argument to retryOnAppResume so that when we create resumeListener, there is no reassignment of a function argument.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppState.removeEventListener was removed in react-native 0.70, after being deprecated for over a year. Anybody using react-native 0.70 will experience an unhandled TypeError when trying to invoke removeEventListener.
Replace the usage of removeEventListener with the
remove()method on the subscription returned by addEventListener.Stop reassigning the resumeListener argument. It's a bad practice to reassign function arguments, and it is common to have an eslint rule to block this. Rename the argument to retryOnAppResume so that when we create resumeListener, there is no reassignment of a function argument.