Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Fix NPE when invoking copyNecessaryFilesFromCurrentPackage() method on Android #2566

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

robxyy
Copy link
Contributor

@robxyy robxyy commented Aug 17, 2023

Fix #2087. It looks like NPE is caused by CodePushUpdateManager.java#L79. When invoking copyNecessaryFilesFromCurrentPackage() method, If currentPackageFolderPath is null, copying currentPackageFolderPath to newUpdateFolderPath will be discarded.

@robxyy robxyy requested a review from a team as a code owner August 17, 2023 03:33
@DmitriyKirakosyan
Copy link
Contributor

Hi @robxyy , thank you for the contribution! Let me leave a couple of comments on your change.

@DordeDimitrijev
Copy link
Contributor

Hi @robxyy these changes were reverted from release 8.3.0 of rn-codepush and latest 8.3.1 hotfix doesn't include them. Reason behind this is that customers reported rollbacks of update and I traced it back to these changes. If you wish to keep these changes and resolve this issue take a look #2725

@robxyy
Copy link
Contributor Author

robxyy commented Jul 29, 2024

Hi @robxyy these changes were reverted from release 8.3.0 of rn-codepush and latest 8.3.1 hotfix doesn't include them. Reason behind this is that customers reported rollbacks of update and I traced it back to these changes. If you wish to keep these changes and resolve this issue take a look #2725

Sorry to hear that. I missed FileUtils.copyDirectoryContents(currentPackageFolderPath, newPackageFolderPath);, and I will push a PR later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants