Move macOS CocoaPods additions upstream #214
Labels
Comments
alloy
added a commit
that referenced
this issue
Jan 7, 2020
alloy
added a commit
that referenced
this issue
Jan 7, 2020
alloy
added a commit
that referenced
this issue
Jan 9, 2020
alloy
added a commit
that referenced
this issue
Jan 28, 2020
* [RNTester] Check-in pod install artefacts * [RNTester] Add CameraRoll pod dependency back At least for now so we’re in sync with upstream v0.60.0 * [RNTester] First pass at adding CocoaPods based macOS target * [RNTester] Add notifications pod to macOS target * [CocoaPods] Make RCTText pod build for macOS * [CocoaPods] make RCTLinking pod build for macOS * [CocoaPods] Exclude more files from RCTText pod * [CocoaPods] Make Core pod build for macOS * [CocoaPods] Exclude turbomodule sample from macOS * [RNTester] Update CocoaPods artefact * [RNTester] Update macOS target to follow non-pods version * [CocoaPods] Tag all macOS changes to ease updating #214 * [RNTester] Remove development team references This change is already made upstream in commit facebook@9ece5bda, so when that is merged in this commit can be skipped. Until then, not making this change will just lead to file thrashing. * [RNTester] Import Xcode artefact This change is already made upstream in commit facebook@c1845810, so when that is merged in this commit can be skipped. Until then, not making this change will just lead to file thrashing. * [RNTester] Start Metro on launch of macOS product * [RCTRedBox] Fix -[RCTRedBoxWindow dismiss] on macOS As per https://www.thecave.com/2015/08/10/dispatch-async-to-main-queue-doesnt-work-with-modal-window-on-mac-os-x/#update2 the main queue is already executing a block when we start the new modal runloop and as the main queue is a serial queue it won’t perform new work until the current block is finished. In short, the task is queued, but will never be performed by GCD. This change side-steps GCD and instead directly invokes -dismiss on the main thread.
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: