Skip to content

[0.78] Build failure when Hermes is enabled #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tido64 opened this issue May 20, 2025 · 1 comment · Fixed by #2500
Open

[0.78] Build failure when Hermes is enabled #2499

tido64 opened this issue May 20, 2025 · 1 comment · Fixed by #2500
Labels
bug Something isn't working Needs: Triage 🔍

Comments

@tido64
Copy link
Member

tido64 commented May 20, 2025 •
edited
Loading

Environment

react-native -v: 0.78.2
npm ls react-native-macos: 0.78.3
node -v: 22.15.0
npm -v: 10.9.2
yarn --version: 4.6.0
xcodebuild -version: 16.2

Steps to reproduce the bug

  1. Enable Hermes
  2. pod install
  3. Notice during Fetching podspec for `hermes-engine` from … that it outputs [Hermes] Using the latest commit from main. instead of [Hermes] Using release tarball from URL: …

Expected Behavior

During pod install, prebuilt Hermes artifacts should be used

Actual Behavior

During pod install, Hermes is set to build from source

Reproducible Demo

https://github.com/microsoft/react-native-test-app/actions/runs/15133204265/job/42540038311

Additional context

It looks like the function for determining latest version is failing because only the four (?) latest versions are returned from Maven:

% curl -s https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/maven-metadata.xml
<?xml version="1.0" encoding="UTF-8"?>
<metadata>
  <groupId>com.facebook.react</groupId>
  <artifactId>react-native-artifacts</artifactId>
  <versioning>
    <latest>0.80.0-rc.2</latest>
    <release>0.80.0-rc.2</release>
    <versions>
      <version>0.79.2</version>
      <version>0.80.0-rc.0</version>
      <version>0.80.0-rc.1</version>
      <version>0.80.0-rc.2</version>
    </versions>
    <lastUpdated>20250519194503</lastUpdated>
  </versioning>
</metadata>
@tido64 tido64 added the bug Something isn't working label May 20, 2025
@tido64 tido64 mentioned this issue May 20, 2025
Merged
tido64 added a commit that referenced this issue May 20, 2025
@tido64
fix: fix build failure with older versions and Hermes (#2500)
ce68f92 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
@Saadnajmi Saadnajmi reopened this May 20, 2025
@Saadnajmi
Copy link
Collaborator

Not closed as we haven't back ported and released a new 0.78 patch version with the fix yet.

tido64 added a commit that referenced this issue May 21, 2025
@tido64
fix: fix build failure with older versions and Hermes (#2500)
3af92e1 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
tido64 added a commit that referenced this issue May 21, 2025
@tido64
fix: fix build failure with older versions and Hermes (#2500)
881be33 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
tido64 added a commit that referenced this issue May 21, 2025
@tido64
fix: fix build failure with older versions and Hermes (#2500)
bbab65b 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
tido64 added a commit that referenced this issue May 21, 2025
@tido64
fix: fix build failure with older versions and Hermes (#2500)
9fbe20b 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
tido64 added a commit that referenced this issue May 21, 2025
@tido64
fix: fix build failure with older versions and Hermes (#2500)
e6090fc 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
This was referenced May 21, 2025
Merged
Open
Merged
Merged
Merged
tido64 added a commit to microsoft/react-native-test-app that referenced this issue May 21, 2025
@tido64
chore(macos): fix macOS + Hermes not using prebuilt artifacts
9b35382 
Upstream: microsoft/react-native-macos#2499
tido64 added a commit to microsoft/react-native-test-app that referenced this issue May 21, 2025
@tido64
chore(macos): fix macOS + Hermes not using prebuilt artifacts
716a339 
Upstream: microsoft/react-native-macos#2499
@tido64 tido64 mentioned this issue May 21, 2025
Merged
5 tasks
tido64 added a commit that referenced this issue May 21, 2025
@tido64
fix(0.74): fix build failure with older versions and Hermes (#2501)
58cc833 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
tido64 added a commit that referenced this issue May 21, 2025
@tido64
fix(0.76): fix build failure with older versions and Hermes (#2503)
3db461e 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
tido64 added a commit that referenced this issue May 21, 2025
@tido64
fix(0.77): fix build failure with older versions and Hermes (#2504)
a0587d6 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
tido64 added a commit that referenced this issue May 21, 2025
@tido64
fix(0.78): fix build failure with older versions and Hermes (#2505)
4890b4f 
## Summary:

`findLastestVersionWithArtifact` fails to find older versions of Hermes
prebuilds because the Maven endpoint it uses does not return all
versions.

Resolves #2499

## Test Plan:

`pod install` output from RNTA with RN 0.78.2 and RNM 0.78.3

![image](https://github.com/user-attachments/assets/a6984ba0-87c0-4304-95d1-4a5b054b44fa)
tido64 added a commit to microsoft/react-native-test-app that referenced this issue May 21, 2025
@tido64
ci(macos): temporarily disable Hermes builds
bc5dd85 
Upstream: microsoft/react-native-macos#2499
tido64 added a commit to microsoft/react-native-test-app that referenced this issue May 21, 2025
@tido64
ci(macos): temporarily disable Hermes builds
11e742f 
Upstream: microsoft/react-native-macos#2499
tido64 added a commit to microsoft/react-native-test-app that referenced this issue May 21, 2025
@tido64
ci(macos): temporarily disable Hermes builds (#2479)
a451e8c 
Upstream: microsoft/react-native-macos#2499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Needs: Triage 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix build failure with older versions and Hermes microsoft/react-native-macos
2 participants
@tido64 @Saadnajmi