Skip to content

AlertMacOS should be deprecated in favor of Alert #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tom-un opened this issue May 8, 2020 · 5 comments
Closed

AlertMacOS should be deprecated in favor of Alert #354

tom-un opened this issue May 8, 2020 · 5 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed Stale
Milestone

Comments

@tom-un
Copy link
Collaborator

tom-un commented May 8, 2020

Upstream react-native has Alert which works on iOS and Android.
Alert has an options argument that can contains a couple Android specific options.
AlertIOS also exists with some iOS specific options, but has been deprecated upstream.
AlertMacOS was created in the fork to be similar to AlertIOS and address macOS specific concerns.
AlertMacOS should now be deprecated and replaced by additional macOS specific options in the Alert options argument.

The macOS specific keys which are currently implemented under the covers in the RCTAlertManager.alertWithArgs method are:

    defaultInputs?: DefaultInputsArray,
    modal?: ?boolean,
    critical?: ?boolean,

The DefaultInputsArray is an array of objects each with:

  /**
   * Default input
   */
  default?: string,
  /**
   * Placeholder input
   */
  placeholder?: string,

to set the default text and placeholder string of the text inputs. It can contain 1 or 2 objects: 2 objects if the alert type is login-password

modal makes the Alert appear as a modal dialog instead of a sheet.

critical makes the Alert icon an exclamation mark instead of the app icon.

@ghost ghost added the Needs: Triage 🔍 label May 8, 2020
@tom-un tom-un mentioned this issue May 8, 2020
4 tasks
@tom-un tom-un added good first issue Good for newcomers help wanted Extra attention is needed and removed Needs: Triage 🔍 labels May 12, 2020
@anhdevit
Copy link

How can I fix that issue? @tom-un

@github-actions
Copy link

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 20, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@Saadnajmi Saadnajmi reopened this Jun 27, 2022
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as completed Jul 5, 2022
@Saadnajmi Saadnajmi reopened this Dec 6, 2022
@Saadnajmi Saadnajmi self-assigned this Dec 6, 2022
@Saadnajmi Saadnajmi moved this to In Progress in 0.71 merge Dec 6, 2022
@Saadnajmi Saadnajmi added this to the 0.71 milestone Dec 6, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

Repository owner moved this from In Progress to Done in 0.71 merge Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed Stale
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants