Make RCTBundleManager's bundleURL a strong property #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
approved these changes
Feb 15, 2022
Saadnajmi
reviewed
Feb 15, 2022
Saadnajmi
approved these changes
Feb 15, 2022
HeyImChris
reviewed
Feb 16, 2022
HeyImChris
approved these changes
Feb 16, 2022
4 tasks
amgleitman
added a commit
that referenced
this pull request
Feb 17, 2022
…y-pick-1025 [0.66-stable cherry pick #1025] Make RCTBundleManager's bundleURL a strong property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
We've seen a downstream compilation error where RCTBundleManager's bundleURL property isn't given a good memory management attribute. Making this property strong seems like the right thing to do here, since if someone is interested in knowing this URL they might as well hold a strong reference to it.
Test Plan
Validated that RNTester still compiles.