Skip to content

Adding step to build rn-tester app for android in PR pipeline #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rasaha91
Copy link

@rasaha91 rasaha91 commented Feb 19, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Cherry picking a change to build rn-tester as part of the android pr. Building the rn-tester app for Android was broken due to a missed patch update. Building the rn-tester app wasn't done as part of the PR pipeline, which is why it wasn't caught.

Changelog

[Android] [Added] - Cherry picking adding step in PR pipeline to build the rn-tester app for android to 0.66-stable

Test Plan

Cherry pick of change in main.

@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 4a59492

@rasaha91 rasaha91 requested a review from mganandraj February 22, 2022 21:00
@rasaha91 rasaha91 marked this pull request as ready for review February 22, 2022 21:00
@rasaha91 rasaha91 requested a review from alloy as a code owner February 22, 2022 21:00
@rasaha91 rasaha91 merged commit 3b9c086 into microsoft:0.66-stable Feb 22, 2022
@rasaha91 rasaha91 deleted the 0.66-cherry-pick-build-rntester-pr branch February 22, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants