Skip to content

[0.64] Enable the address sanitizer in our CI to catch memory corruption imm… #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

HeyImChris
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

We need to have ASAN enabled and the clang static analyzer on for our builds.

git cherry-pick 75775cabb2647023760e07b867a0cbefa4b4adea

…ediately (microsoft#1014)

* android

* add a new build job with asan enabled

* xcconfigs & test crash page

* lock merge

* don't enable ASAN from yml

* fix flow

* yarn lint

* run static analysis on release unit/integration

* fix merge conflicts with master

* yarn lint and pathing fix

* static analyzer & sanitizer building

* ios enablesanitizer

* disable thread sanitizer

* remove clang static analyzer sim filter

* add back arm64 excluded arch

* add back arm64 exclusion

* ios sanitizer scheme

* enable asan from ios schemes

* podfile.lock conflicts
@HeyImChris HeyImChris requested a review from alloy as a code owner February 19, 2022 06:31
@HeyImChris HeyImChris self-assigned this Feb 19, 2022
@HeyImChris HeyImChris changed the title Enable the address sanitizer in our CI to catch memory corruption imm… [0.64] Enable the address sanitizer in our CI to catch memory corruption imm… Feb 19, 2022
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 468ddba

@HeyImChris HeyImChris merged commit f065baa into microsoft:0.64-stable Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants