Skip to content

Cleaning up parts of android-pr.yml #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

rasaha91
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Trying to execute the PR steps locally (via an automatically generated script) can result in errors when invoking the generated script multiple times. This PR attempts to fix that, and also perform some additional clean up like giving a display name to a step, generating RNTesterApp.android.bundle to the expected location, and use Unix style paths instead of windows paths

Changelog

[Android] [Fixed] - Cleaning up Android PR to allow for repeated executions without error.

Test Plan

Running the PR pipeline and executing locally.

@rasaha91 rasaha91 requested a review from mganandraj February 23, 2022 02:05
@rasaha91 rasaha91 requested a review from alloy as a code owner February 23, 2022 02:05
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS against d395dcd

@rasaha91 rasaha91 merged commit a30f37b into microsoft:0.66-stable Feb 23, 2022
@rasaha91 rasaha91 deleted the cherry-pick-pr-cleanup branch February 23, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants