Skip to content

remove references to RCTDynamicColor #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2022
Merged

remove references to RCTDynamicColor #1060

merged 1 commit into from
Mar 2, 2022

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

In #1028 I removed RCTDynamicColor.h/.m . There was still an explicit reference to the class in our unit tests. I'm not sure why that wasn't caught.

Changelog

[macOS] [Fixed] - Removed reference to RCTDynamicColor in our unit tests.

Test Plan

CI should pass.

@Saadnajmi Saadnajmi requested a review from a team as a code owner March 2, 2022 19:57
@Saadnajmi Saadnajmi merged commit ff4f71d into microsoft:main Mar 2, 2022
@Saadnajmi Saadnajmi deleted the dynamic-color-fallout branch March 2, 2022 22:23
@Saadnajmi Saadnajmi mentioned this pull request Mar 2, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeyImChris HeyImChris HeyImChris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saadnajmi @HeyImChris