Remove AlertMacOS in favor of Alert & promptMacOS #1548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Dec 6, 2022
Saadnajmi
commented
Dec 7, 2022
amgleitman
previously requested changes
Dec 7, 2022
ghost
added
Saadnajmi
changed the title
Saadnajmi
changed the title
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 8, 2022
Summary: `AlertIOS` was deprecated and removed long ago (e2bd7db) but there continues to be a test page with the name `AlertIOS` in RN-Tester. `AlertIOSExample.js` contains valid examples of how to use `Alert.prompt()` so it's worth keeping them around. Let's move those into `AlertExample.js` and remove `AlertIOSExample.js`. While we're here, let's do some extra fixes to the test page: - Remove `showsIndividualExamples = true`. For whatever reason, I needed to remove this to show the examples properly... - Convert all uses of `<TouchableHighlight>` with `<Pressable>`. The latter replaces the former, so I thought that made sense.. Some extra context: In React Native macOS, we had forked `AlertIOS` into `AlertMacOS`, with a corresponding example page. This PR was made while working on removing those (microsoft#1548). ## Changelog [INTERNAL] [CHANGED] - Moved `Alert.prompt` examples into common rn-tester test page Pull Request resolved: #35586 Test Plan: Test page shows up fine on iOS .  Reviewed By: lunaleaps Differential Revision: D41825889 Pulled By: NickGerleman fbshipit-source-id: 82e4405b1f3a1ccb558b5a5038a90416e7a32c29
4 tasks
|
test Sheets? |
harrieshin
reviewed
Dec 9, 2022
|
wait in your Video sheet doesn't look like sheets? |
I think Ventura made them floating windows |
if that's really the case, we should document expected behaviors? |
Once we merge to 0.71, we will have typescript types for files. When there, we can update the documentation in our repo. You can see I updated the iOS documentation in Alert.d.ts in my upstream PR here: facebook#35586 |
harrieshin
approved these changes
Dec 9, 2022
Deprecate AlertMacOS in favor of Alert move UIAlertController define to RCTAlertController.h define only on macos target revert podfile.lock
Fix merge issue Get rid of workaround maybe? Better type? Fix codegen error Remove AlertMacOS altogether Space Refactor test page logic Delete AlertIOS Make promptMacOS work make example load Fix Alert.prompt() Move examples to AlertIOSExample Remove changes to AlertExample Remove more fix error More fixed
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: `AlertIOS` was deprecated and removed long ago (facebook@e2bd7db) but there continues to be a test page with the name `AlertIOS` in RN-Tester. `AlertIOSExample.js` contains valid examples of how to use `Alert.prompt()` so it's worth keeping them around. Let's move those into `AlertExample.js` and remove `AlertIOSExample.js`. While we're here, let's do some extra fixes to the test page: - Remove `showsIndividualExamples = true`. For whatever reason, I needed to remove this to show the examples properly... - Convert all uses of `<TouchableHighlight>` with `<Pressable>`. The latter replaces the former, so I thought that made sense.. Some extra context: In React Native macOS, we had forked `AlertIOS` into `AlertMacOS`, with a corresponding example page. This PR was made while working on removing those (microsoft#1548). ## Changelog [INTERNAL] [CHANGED] - Moved `Alert.prompt` examples into common rn-tester test page Pull Request resolved: facebook#35586 Test Plan: Test page shows up fine on iOS .  Reviewed By: lunaleaps Differential Revision: D41825889 Pulled By: NickGerleman fbshipit-source-id: 82e4405b1f3a1ccb558b5a5038a90416e7a32c29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Copy of #662 to try and land this change.
RN Core once had a separate
AlertandAlertIOS, but have since deprecated and removed the latter. We had forkedAlertIOSintoAlertMacOS. It's been deprecated for a while, let's just remove it to get rid of unnecessary diffs.To this effect, I found some unnecessary example code in RN Core that we can cleanup for even less diffs. Soo overall, the order of operations is..
Alert.PromptMacOS(this PR)AlertIOSExamplepage (this PR)AlertIOSExamplesintoAlertExamples([RNTester] Merge AlertIOSExample page into AlertExample page facebook/react-native#35586)AlertExmaples. (Some future PR).Changelog
[macOS] [Deprecated] - Deprecate AlertMacOS in favor of Alert
Test Plan
Existing RNTester tests still work.
Screen.Recording.2022-12-08.at.3.08.34.PM.mov
Microsoft Reviewers: Open in CodeFlow