Skip to content

Remove comment on merging stable branches -> main #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Back in #944 , I had added a comment about merging stable branches into our main branch. We have then since learned and documented that we shouldn't be doing that: main should merge to main, and stable should either have merges from upstream stable, or cherry picks.

Let's remove the comment, removing another diff from our repo.

Changelog

[Internal] [Removed] - Remove comment on merging stable branches -> main

Test Plan

Removing a comment, nothing should be affected.

@Saadnajmi Saadnajmi requested a review from a team as a code owner December 19, 2022 18:21
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: e71b094
Branch: main

@Saadnajmi Saadnajmi mentioned this pull request Dec 19, 2022
4 tasks
@Saadnajmi Saadnajmi merged commit ec1a9f2 into microsoft:main Dec 22, 2022
@Saadnajmi Saadnajmi deleted the remove-comment branch January 15, 2023 23:46
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants