Adding logging support on droid and logging failure message #17

rohitjain85 · 2019-03-22T09:38:15Z

Adding logging support in V8Runtime for droid and logging failure message during exception.

Please select one of the following

I am removing an existing difference between facebook/react-native and Microsoft/react-native 👍
I am cherry-picking a change from Facebook's react-native into Microsoft/react-native 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Description of changes

(give an overview)

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

ReactCommon/jsi/V8Runtime_shared.cpp

…icrosoft#23) the default system color instead.

…to v58-ms

rohitjain85 · 2019-04-01T06:46:58Z

@msethims is added to the review. #Closed

This reverts commit 0a0d7d1.

…t tests

acoates-ms · 2019-04-02T04:42:45Z

/azp run

azure-pipelines · 2019-04-02T04:42:52Z

No pipelines are associated with this pull request.

msethims · 2019-04-02T08:42:51Z

ReactCommon/jsi/V8Runtime_shared.cpp

@@ -283,7 +285,9 @@ namespace facebook { namespace v8runtime {
        sstr << stack_trace_string2 << std::endl;
      }

-      throw jsi::JSError(*this, sstr.str());
+      std::string errorMessage{ sstr.str() };
+      Log(errorMessage, 3 /*logLevel*/);


need to comment the category of this magic number

msethims

rohitjain85 · 2019-04-02T08:46:17Z

/azp run

azure-pipelines · 2019-04-02T08:46:22Z

No pipelines are associated with this pull request.

…into logging

pull-bot · 2019-04-02T09:02:06Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️	📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️	📋 Release Notes - This PR appears to be missing Release Notes.
⚠️	❗ Big PR - This PR is extremely unlikely to get reviewed because it touches 95392 lines.

Generated by 🚫 dangerJS

…tion for existing view (facebook#51294) Summary: Pull Request resolved: facebook#51294 changelog: [internal] Fix a crash where a node that is supposed to be culled doesn't get visited because culling context is not updated. The differentiator would generate a create instruction for a view that already exists. Stack trace for the crash: ``` * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT * frame #0: 0x0000000111740874 libsystem_kernel.dylib`__pthread_kill + 8 frame #1: 0x00000001117aa2ec libsystem_pthread.dylib`pthread_kill + 264 frame #2: 0x0000000180171ea8 libsystem_c.dylib`abort + 100 frame microsoft#3: 0x00000001802b0144 libc++abi.dylib`abort_message + 128 frame microsoft#4: 0x000000018029fe4c libc++abi.dylib`demangling_terminate_handler() + 296 frame microsoft#5: 0x000000018006f220 libobjc.A.dylib`_objc_terminate() + 124 frame microsoft#6: 0x00000001375d1964 INFRAFramework`meta_terminate() + 5468 frame microsoft#7: 0x00000001802af570 libc++abi.dylib`std::__terminate(void (*)()) + 12 frame microsoft#8: 0x00000001802b2498 libc++abi.dylib`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) + 32 frame microsoft#9: 0x00000001802b2478 libc++abi.dylib`__cxa_throw + 88 frame microsoft#10: 0x0000000180093904 libobjc.A.dylib`objc_exception_throw + 384 frame microsoft#11: 0x0000000180e6999c Foundation`-[NSAssertionHandler handleFailureInFunction:file:lineNumber:description:] + 268 frame microsoft#12: 0x000000031a3bcfc8 XPLAT_6_Framework`-[RCTComponentViewRegistry dequeueComponentViewWithComponentHandle:tag:] + 528 frame microsoft#13: 0x000000031a3ccdec XPLAT_6_Framework`RCTPerformMountInstructions(std::__1::vector<facebook::react::ShadowViewMutation, std::__1::allocator<facebook::react::ShadowViewMutation>> const&, RCTComponentViewRegistry*, RCTMountingTransactionObserverCoordinator&, int) + 356 frame microsoft#14: 0x000000031a3ccc7c XPLAT_6_Framework`-[RCTMountingManager performTransaction:]::$_1::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) const + 80 frame microsoft#15: 0x000000031a3ccc20 XPLAT_6_Framework`decltype(std::declval<-[RCTMountingManager performTransaction:]::$_1&>()(std::declval<facebook::react::MountingTransaction const&>(), std::declval<facebook::react::SurfaceTelemetry const&>())) std::__1::__invoke[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40 frame microsoft#16: 0x000000031a3ccbc8 XPLAT_6_Framework`void std::__1::__invoke_void_return_wrapper<void, true>::__call[abi:ne190102]<-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&>(-[RCTMountingManager performTransaction:]::$_1&, facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 40 frame microsoft#17: 0x000000031a3ccb94 XPLAT_6_Framework`std::__1::__function::__alloc_func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()[abi:ne190102](facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44 frame microsoft#18: 0x000000031a3cba1c XPLAT_6_Framework`std::__1::__function::__func<-[RCTMountingManager performTransaction:]::$_1, std::__1::allocator<-[RCTMountingManager performTransaction:]::$_1>, void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&) + 44 frame microsoft#20: 0x000000032f219804 XPLAT_1_Framework`std::__1::function<void (facebook::react::MountingTransaction const&, facebook::react::SurfaceTelemetry const&)>::operator()(this=0x000000016d4f0c78, __arg=0x000000016d4f0a10, __arg=0x000000016d4f0978) const at function.h:989:10 frame microsoft#21: 0x000000032f219668 XPLAT_1_Framework`facebook::react::TelemetryController::pullTransaction(this=0x00000003f4680f00, willMount=0x000000016d4f0c98, doMount=0x000000016d4f0c78, didMount=0x000000016d4f0c58) const at TelemetryController.cpp:39:3 frame microsoft#22: 0x000000031a3c5b28 XPLAT_6_Framework`-[RCTMountingManager performTransaction:] + 544 frame microsoft#23: 0x000000031a3c5864 XPLAT_6_Framework`-[RCTMountingManager initiateTransaction:] + 456 frame microsoft#24: 0x000000031a3c5240 XPLAT_6_Framework`__42-[RCTMountingManager scheduleTransaction:]_block_invoke + 308 frame microsoft#25: 0x0000000131f81b84 BOTTOMFramework`__RCTExecuteOnMainQueue_block_invoke + 40 frame microsoft#26: 0x000000018017c788 libdispatch.dylib`_dispatch_call_block_and_release + 24 frame microsoft#27: 0x0000000180197278 libdispatch.dylib`_dispatch_client_callout + 12 frame microsoft#28: 0x00000001801b2fcc libdispatch.dylib`_dispatch_main_queue_drain.cold.7 + 24 frame microsoft#29: 0x000000018018c1c4 libdispatch.dylib`_dispatch_main_queue_drain + 1184 frame microsoft#30: 0x000000018018bd14 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 40 frame microsoft#31: 0x0000000180427fec CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12 frame microsoft#32: 0x00000001804229f8 CoreFoundation`__CFRunLoopRun + 1920 frame microsoft#33: 0x0000000180421e3c CoreFoundation`CFRunLoopRunSpecific + 536 frame microsoft#34: 0x0000000190f62d00 GraphicsServices`GSEventRunModal + 164 frame microsoft#35: 0x0000000185bcec98 UIKitCore`-[UIApplication _run] + 796 frame microsoft#36: 0x0000000185bd3064 UIKitCore`UIApplicationMain + 124 frame microsoft#37: 0x0000000115fbf0bc PRODUCTFramework`main + 200 frame microsoft#38: 0x00000001114293d8 dyld_sim`start_sim + 20 frame microsoft#39: 0x0000000111506b4c dyld`start + 6000 ``` Reviewed By: rubennorte Differential Revision: D74654157 fbshipit-source-id: 9181bcd28524c71d0ca4620bd630dc0baa172386

Adding logging support on droid and logging failure message

6bfd624

rohitjain85 requested a review from acoates-ms as a code owner March 22, 2019 09:38

mganandraj reviewed Mar 22, 2019

View reviewed changes

ReactCommon/jsi/V8Runtime_shared.cpp Outdated Show resolved Hide resolved

Inlining Log()

27aeb81

mganandraj approved these changes Mar 26, 2019

View reviewed changes

rohitjainMS and others added 15 commits March 27, 2019 12:00

Merge remote-tracking branch 'upstream/master' into logging

e185606

Remove default color value for mac ActivityIndicator so that it uses (m…

2a377b9

…icrosoft#23) the default system color instead.

Applying package update to 0.57.0-microsoft.12

540dc61

update mac libraries

9a215f9

lint fixes and merge conflict resolution for Mac

a9f4ec2

put RN58 back

7f3192c

Merge remote-tracking branch 'upstream/v58-ms'

423e380

fix mac build

a1eea05

tv OS .58 fixes

572f973

Fix tvOS

2951db0

Merge 2951db0 into 540dc61

4f9b9df

Applying package update to 0.58.6-microsoft.7

d419d63

Applying package update to 0.58.6-microsoft.8

b18a7c3

delete stale files from the 0.58.6 merge

0a0d7d1

Merge branch 'v58-ms' of https://github.com/Microsoft/react-native in…

162484c

…to v58-ms

HeyImChris and others added 9 commits April 1, 2019 12:34

Revert "delete stale files from the 0.58.6 merge"

656be42

This reverts commit 0a0d7d1.

mac linking libraries for compilation

b49da28

link in libraries and update build phases for Mac integration and uni…

8d15a55

…t tests

Merge 8d15a55 into b18a7c3

80f12c8

Applying package update to 0.58.6-microsoft.9

90818a6

Applying package update to 0.58.6-microsoft.10

d45b230

update imports to get tvOS building

5851151

Merge remote-tracking branch 'msrn/v58-ms'

ede11d1

Dont publish on PRs

6203c6f

Office VSTS Default Agent and others added 2 commits April 2, 2019 04:26

Applying package update to 0.58.6-microsoft.11

625178f

Moving exception flag to LOCAL_CFLAGS to reduce the diff (microsoft#24)

ebee9db

Office VSTS Default Agent and others added 3 commits April 2, 2019 04:44

Applying package update to 0.58.6-microsoft.12

4b07368

Stop RN Tester 64 bit APKs (microsoft#28)

ea5a264

Applying package update to 0.58.6-microsoft.13

e236bd2

msethims reviewed Apr 2, 2019

View reviewed changes

msethims approved these changes Apr 2, 2019

View reviewed changes

rohitjainMS added 3 commits April 2, 2019 14:29

Adding logging support on droid and logging failure message

aa92ba2

Inlining Log()

1af311c

Merge branch 'logging' of https://github.com/rohitjain85/react-native …

2b043b5

…into logging

rohitjainMS added 4 commits April 2, 2019 14:36

Adding logging support on droid and logging failure message

be674f4

Inlining Log()

0fa70fe

Adding logging support on droid and logging failure message

120532b

merging with master

1b03e2f

rohitjain85 closed this Apr 2, 2019

rohitjain85 reopened this Jun 13, 2019

rohitjain85 closed this Jun 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding logging support on droid and logging failure message #17

Adding logging support on droid and logging failure message #17

Uh oh!

rohitjain85 commented Mar 22, 2019 •

edited by markavitale

Loading

Uh oh!

Uh oh!

rohitjain85 commented Apr 1, 2019

Uh oh!

acoates-ms commented Apr 2, 2019

Uh oh!

azure-pipelines bot commented Apr 2, 2019

Uh oh!

msethims Apr 2, 2019

Uh oh!

msethims left a comment

Uh oh!

rohitjain85 commented Apr 2, 2019

Uh oh!

azure-pipelines bot commented Apr 2, 2019

Uh oh!

pull-bot commented Apr 2, 2019 •

edited

Loading

Uh oh!

Uh oh!

Adding logging support on droid and logging failure message #17

Adding logging support on droid and logging failure message #17

Uh oh!

Conversation

rohitjain85 commented Mar 22, 2019 • edited by markavitale Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please select one of the following

Description of changes

Focus areas to test

Microsoft Reviewers: Open in CodeFlow

Uh oh!

Uh oh!

rohitjain85 commented Apr 1, 2019

Uh oh!

acoates-ms commented Apr 2, 2019

Uh oh!

azure-pipelines bot commented Apr 2, 2019

Uh oh!

msethims Apr 2, 2019

Choose a reason for hiding this comment

Uh oh!

msethims left a comment

Choose a reason for hiding this comment

Uh oh!

rohitjain85 commented Apr 2, 2019

Uh oh!

azure-pipelines bot commented Apr 2, 2019

Uh oh!

pull-bot commented Apr 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rohitjain85 commented Mar 22, 2019 •

edited by markavitale

Loading

pull-bot commented Apr 2, 2019 •

edited

Loading