Skip to content

ci: add a pipeline for consuming react-native-macos #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 12, 2021

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 29, 2021

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Add a pipeline for consuming react-native-macos outside of the repository. This should help catch issues earlier (such as #860 or FBReactNativeSpec not being generated).

Changelog

[Internal] [Added] - Add a pipeline for consuming react-native-macos outside the repository

Test Plan

The newline pipeline should install and build react-native-macos. It will fail because FBReactNativeSpec.h/.mm are not being generated.

Sorry, something went wrong.

@tido64 tido64 marked this pull request as ready for review October 29, 2021 17:14
@tido64 tido64 requested a review from alloy as a code owner October 29, 2021 17:14
@tido64 tido64 requested a review from HeyImChris October 29, 2021 17:14
@ghost ghost removed the Needs: Author Feedback label Oct 29, 2021
@acoates-ms
Copy link
Collaborator

Could not find /.ado/apple-node-setup.yml

@tido64
Copy link
Member Author

tido64 commented Nov 10, 2021

It looks like the latest failure on the Integration pipeline is from having both @react-native-community/cli 4.x and 5.x installed. We get auto-linking from 5.x but use config from 4.x, and some of the paths are wrong. At some point, the main branch will get caught up with the latest changes and start using 5.x so this will be resolved eventually. Do you think it makes sense to make sure we always use 5.x, or should we wait till we are caught up?

Edit: Never mind. We can pull the version from package.json. The pipeline now fails because of codegen, which is expected since main hasn't caught up yet.

@tido64 tido64 force-pushed the tido/add-integration-pipeline branch 2 times, most recently from 0f74ce7 to 955ea67 Compare November 10, 2021 09:07
@tido64 tido64 force-pushed the tido/add-integration-pipeline branch from 955ea67 to c004745 Compare November 10, 2021 09:13
@tido64 tido64 merged commit f88f01a into master Nov 12, 2021
@tido64 tido64 deleted the tido/add-integration-pipeline branch November 12, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants