Skip to content

Fixes for publishing from stable branches #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

acoates-ms
Copy link
Collaborator

Porting various fixes I made to the 0.64-stable branch to get publishing working again.

In particular makes publish update the version numbers of various files that were not being bumped before, and the RNTester pod lock file will get updated when the version of its dependencies gets bumped. -- which was previously causing publish to break the lock file, which would cause PRs to start failing.

@acoates-ms acoates-ms requested a review from alloy as a code owner November 1, 2021 19:41
@pull-bot
Copy link

pull-bot commented Nov 1, 2021

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against f8cea11

@acoates-ms acoates-ms merged commit ea0f1ac into microsoft:master Nov 4, 2021
@acoates-ms acoates-ms deleted the updpodlock branch November 4, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants