Skip to content

Disable dev mode on ship builds #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Conversation

HeyImChris
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am making a change required for Microsoft usage of react-native

Summary

Years ago we added in a runtime setting to allow third-party SDX clients to control if they're in debug mode on any builds, regardless of flavor. For the following reasons I'd like to revert this change:

  1. Having this diff with FB upstream caused confusion with clients who don't realize we have this macOS repo specific change
  2. After 3+ years we have zero clients who have communicated using this feature
  3. Debug mode running by accident on ship builds has happened on multiple occasions
  4. We've hit ship related crashers to being on debug mode in ship builds by accident

Changelog

[iOS/macOS] [Feature] - Disabling debugging of ship builds

Test Plan

I can no longer launch the debug menu from ship builds in rn-tester

@HeyImChris HeyImChris requested a review from tom-un November 4, 2021 22:33
@HeyImChris HeyImChris self-assigned this Nov 4, 2021
@HeyImChris HeyImChris requested a review from alloy as a code owner November 4, 2021 22:33
@pull-bot
Copy link

pull-bot commented Nov 4, 2021

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 3240776

@HeyImChris
Copy link
Author

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@HeyImChris
Copy link
Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@HeyImChris HeyImChris merged commit 2bb6d93 into microsoft:master Nov 11, 2021
HeyImChris added a commit to HeyImChris/react-native-macos that referenced this pull request Nov 18, 2021
* revert dev mode on ship builds

* rctuicolor

* remove unused variable

* pod install
HeyImChris added a commit that referenced this pull request Nov 18, 2021
* revert dev mode on ship builds

* rctuicolor

* remove unused variable

* pod install
HeyImChris added a commit to HeyImChris/react-native-macos that referenced this pull request Dec 15, 2021
* revert dev mode on ship builds

* rctuicolor

* remove unused variable

* pod install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants