forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 146
Disable dev mode on ship builds #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Saadnajmi
approved these changes
Nov 5, 2021
/azp run |
Pull request contains merge conflicts. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
HeyImChris
added a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Nov 18, 2021
* revert dev mode on ship builds * rctuicolor * remove unused variable * pod install
4 tasks
HeyImChris
added a commit
that referenced
this pull request
Nov 18, 2021
HeyImChris
added a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Dec 15, 2021
* revert dev mode on ship builds * rctuicolor * remove unused variable * pod install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Years ago we added in a runtime setting to allow third-party SDX clients to control if they're in debug mode on any builds, regardless of flavor. For the following reasons I'd like to revert this change:
Changelog
[iOS/macOS] [Feature] - Disabling debugging of ship builds
Test Plan
I can no longer launch the debug menu from ship builds in rn-tester